Skip to content

Conversation

@deepfire
Copy link
Contributor

@deepfire deepfire commented Jun 2, 2017

Tested to generate a nix expression sufficiently good to start building cardano-sl.

@deepfire deepfire requested a review from jmitchell June 2, 2017 17:52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reorder this so the URI comes last. It makes stack2nix --help more readable.

Otherwise, looks great! Thanks 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The record fields need to be reordered to match.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, 😊..

@jmitchell jmitchell merged commit 5774157 into master Jun 2, 2017
@jmitchell jmitchell deleted the system-ghc-flag branch June 9, 2017 17:13
@nh2 nh2 mentioned this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants